Allow opening absolute device names on Windows - #61
Open
codyps wants to merge 1 commit into
Open
Conversation
codyps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm writing some code on windows that uses CM_Register_Notification to get events when serial ports are plugged in. Those events give a complete device path (for example:
\\?\usb#vid_2109&pid_0822#msft30000000001#{f18a0e88-c30c-11d0-8815-00a0c906bed8}) and I'd like to be able to pass that name directly to open a serial port.I currently can't do that because mio-serial unconditionally modifies the path. This change checks if the path is already an absolute one (starts with a backslash:
\) so that users can pass device paths like the one above or the absolute com paths (like the ones that are constructed today).