chore(ci): pin sideload builds to LumeEngine v0.1.6 - #214
Merged
Conversation
main now calls PlayerConfiguration.preferredAudioLanguages, added in the engine alongside #211. v0.1.5 predates it, so a sideload run would check out an engine that cannot compile the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unbreaks sideload CI after #211.
mainnow callsPlayerConfiguration.preferredAudioLanguages, which landed in LumeEngine via bilipp/LumeEngine#32.ENGINE_REFstill defaulted tov0.1.5, which predates that commit — verified:git grep preferredAudioLanguages v0.1.5returns nothing. A sideload release run would have checked out an engine that cannot compile the app.Bumps the default to
v0.1.6, tagged at the engine's merge commit and verified to carry the API. Theengine_refworkflow input still overrides it.Why this wasn't caught
Every build in #211 resolved
../LumeEnginefrom the local sibling checkout, which already had the change. Nothing in the PR matrix exercises the pinned tag.Testing
v0.1.6exists on the engine remote and containspreferredAudioLanguagessideload-release.ymlisworkflow_dispatch-only; the next manual run is the real check