Reject configs where an output.write_* flag has no matching extractio… - #33
Merged
Conversation
…n flag output.write_branch_csv/write_node_csv/write_radius silently no-op when their paired extraction.branches/nodes/mask_radius flag is off - no error, no warning, and `maskel validate` still printed "Configuration is valid." Enforced in PipelineConfig.from_dict (covers both `maskel validate` and `maskel run --config`) rather than at construction time, since a config built incrementally in napari-maskel's widget can be transiently inconsistent mid-edit without ever going through from_dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n flag
output.write_branch_csv/write_node_csv/write_radius silently no-op when their paired extraction.branches/nodes/mask_radius flag is off - no error, no warning, and
maskel validatestill printed "Configuration is valid." Enforced in PipelineConfig.from_dict (covers bothmaskel validateandmaskel run --config) rather than at construction time, since a config built incrementally in napari-maskel's widget can be transiently inconsistent mid-edit without ever going through from_dict.