Fix test collection broken by merging PRs #32 and #35 together - #36
Merged
Conversation
PR #32 (fix/api-docs-correctness) renamed build_vessel_graph -> build_skeleton_graph in maskel/features.py. PR #35 (fix/degenerate-object- shapes), branched from main before #32 merged, added a new tests/test_pipeline.py import of the old name - no textual conflict since #32 never touched test_pipeline.py, so GitHub merged both cleanly, but the result was an ImportError at collection time that failed the entire test session, not just one test. Also independently caught: PR #34 (fix/crash-on-uniform-mask) and PR #35 both added equivalent coverage for the same gaps (a 2D skimage bit-identical test, prune_spurs pipeline integration, degenerate single-pixel/border- touching objects) without either being aware of the other. Beyond being redundant, PR #35's TestPruneSpursIntegration silently shadowed #34's same-named class - Python doesn't error on class redefinition, so #34's version of that test class never actually ran once merged (ruff's F811 catches this, nothing else does). Kept #34's versions (a convergence-based _no_prunable_spurs_remain helper, and an extra mixed-isolated-pixel case neither redundant copy had) and removed #35's duplicates. uv run pytest: 294 passed. ruff check/format: clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #32 (fix/api-docs-correctness) renamed build_vessel_graph -> build_skeleton_graph in maskel/features.py. PR #35 (fix/degenerate-object- shapes), branched from main before #32 merged, added a new tests/test_pipeline.py import of the old name - no textual conflict since #32 never touched test_pipeline.py, so GitHub merged both cleanly, but the result was an ImportError at collection time that failed the entire test session, not just one test.
Also independently caught: PR #34 (fix/crash-on-uniform-mask) and PR #35 both added equivalent coverage for the same gaps (a 2D skimage bit-identical test, prune_spurs pipeline integration, degenerate single-pixel/border- touching objects) without either being aware of the other. Beyond being redundant, PR #35's TestPruneSpursIntegration silently shadowed #34's same-named class - Python doesn't error on class redefinition, so #34's version of that test class never actually ran once merged (ruff's F811 catches this, nothing else does). Kept #34's versions (a convergence-based _no_prunable_spurs_remain helper, and an extra mixed-isolated-pixel case neither redundant copy had) and removed #35's duplicates.
uv run pytest: 294 passed. ruff check/format: clean.