[pull] develop from smartcontractkit:develop - #569
Merged
Conversation
* core/services/gateway: gate user traffic on relay readiness * core/services/gateway: use generic DON readiness terms * core/services/gateway/connectionmanager.go: describe traffic readiness threshold * core/services/gateway: log disconnected readiness nodes * core/services/gateway/network: fix readiness test lint * core/services/gateway/monitoring/metrics_test.go: keep readiness metrics test serial
#23524) * plugins/plugins.public.yaml: update confidential plugin refs for 1.4.0 * fix test --------- Co-authored-by: vreff <104409744+vreff@users.noreply.github.com>
…#23407) * add fetch on demand ref resolution for changelog script * normalize ccip image tag formatting to actual git tags * make more product-agnostic * lint
…#23514) * fix: wrapp user errors on vaultSecretError to avoid misclassification as system errors * fix: keep vault system errors classified as internal (#23517) * fix: keep vault system errors classified as internal The vault OCR plugin already classifies per-secret failures via userFacingError: user errors surface their raw message, while system failures are replaced with a generic fallback ("failed to handle get secret request"). That classification is lost at the protobuf SecretResponse.error string boundary, so the relay handler cannot recover the Go type. vaultSecretError.Unwrap previously returned a *vaulttypes.UserError unconditionally, which made IsUserError true for every per-secret error — including the system fallback. A KV-store outage or decryption failure would have been mapped to jsonrpc.ErrInvalidParams (a user error) instead of ErrInternal, suppressing system-error alerts: the opposite of the intended fix. Export the fallback as vaulttypes.SecretGetSystemErrorFallback so the vault plugin and relay handler share one marker, and have Unwrap return nil for that message so IsUserError reports false. User errors still unwrap to a UserError and map to ErrInvalidParams; system errors keep falling through to ErrInternal. Co-Authored-By: Claude <noreply@anthropic.com> * fix lint --------- Co-authored-by: Claude <noreply@anthropic.com> * fix lint 2 * fix lint * chore: add explicit isUser flag * get rid of useless wrapper * fix lint --------- Co-authored-by: vreff <104409744+vreff@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
* lint(core/capabilities/ccip/ccipsolana): fix violations (batch_003) * lint(core/capabilities/ccip): fix violations (batch_004) * lint: ccipocr3 rename * lint
* core: misc fixes * feedback
bump pinned curl version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )