Skip to content

feat(bitwarden-delivery-tools): add stacked pull request support - #218

Draft
withinfocus wants to merge 1 commit into
fix/stack-aware-false-positivesfrom
feat/stacked-pr-support
Draft

feat(bitwarden-delivery-tools): add stacked pull request support#218
withinfocus wants to merge 1 commit into
fix/stack-aware-false-positivesfrom
feat/stacked-pr-support

Conversation

@withinfocus

@withinfocus withinfocus commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

gh stack is in use across the organization and the delivery plugin knew nothing about it.

The new stacking-pull-requests skill owns what gh stack does not: Bitwarden's per-PR conventions, multiplied by the number of layers. It plans the layers, registers them with gh stack init, gates each one, puts the ticket key and type prefix and template body and label on every layer, previews the whole chain once, and merges bottom to top. The gh stack command surface itself is delegated to GitHub's own gh-stack skill, behind an availability check with a single-branch fallback when it is missing.

perform-preflight gains a Stacked Branches section covering the layer you are on. creating-pull-request and committing-changes now hand off instead of competing for stack phrasings.

The trigger eval ships with 20 cases and no recorded baseline, and the creating-pull-request and committing-changes baselines are stale. Each needs roughly 60 claude -p runs to record, which has not been done.

bitwarden-delivery-tools 3.1.0 to 3.2.0.

@withinfocus withinfocus added the ai-review Request a Claude code review label Aug 26, 2026
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

Comment thread plugins/bitwarden-delivery-tools/skills/creating-pull-request/SKILL.md Outdated
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from eda42c0 to 73176c6 Compare August 27, 2026 13:22
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/evals/README.md Outdated
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from 73176c6 to d2f763c Compare August 27, 2026 13:36
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from d2f763c to a7a868a Compare August 27, 2026 13:56
Comment thread plugins/bitwarden-delivery-tools/skills/creating-pull-request/SKILL.md Outdated
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from a7a868a to efaeccc Compare August 27, 2026 14:15
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from efaeccc to 80a356d Compare August 27, 2026 14:30
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from 80a356d to 98dedc0 Compare August 27, 2026 14:31
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from 98dedc0 to 677b665 Compare August 27, 2026 14:53
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from 677b665 to b3a8547 Compare August 27, 2026 15:10
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from b3a8547 to 382b8a1 Compare August 27, 2026 15:32
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from 9f7eb90 to 6d4fbd5 Compare September 1, 2026 12:38
@withinfocus
withinfocus force-pushed the feat/stacked-pr-support branch from 6d4fbd5 to dea8b2b Compare September 1, 2026 13:30
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/evals/README.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/perform-preflight/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/perform-preflight/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/creating-pull-request/evals/README.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/creating-pull-request/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/committing-changes/evals/README.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/perform-preflight/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/stacking-pull-requests/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/skills/perform-preflight/SKILL.md Outdated
Comment thread plugins/bitwarden-delivery-tools/CHANGELOG.md
GitHub's gh-stack extension is now in use across the organization, but
Bitwarden's PR conventions are per-PR and `gh stack submit` accepts no
title, body, or label flag — so a stack submitted the documented way
ships every layer with a generated title, no `t:` label, and no template
body.

The new `stacking-pull-requests` skill owns that conventions layer and
delegates every `gh stack` command to GitHub's own `gh-stack` skill,
gating on both the extension and the skill being present and falling
back to a single-branch PR when they are not. The three existing
mechanics skills gain the per-layer semantics a stack implies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant