[deps]: Update typescript to v7 - #524
Conversation
80412be to
45125a6
Compare
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES Renovate bumps Code Review Details
Dependency Changes
|
| "ts-node": "10.9.2", | ||
| "tslib": "2.8.1", | ||
| "typescript": "6.0.3" | ||
| "typescript": "7.0.2" |
There was a problem hiding this comment.
❓ QUESTION: TypeScript v6 → v7 is the native compiler rewrite — was ts-node compatibility verified?
Why this bump differs from a normal major
The lock file shows this is not an incremental major: tsserver is dropped from bin, and 20 @typescript/typescript-<os>-<arch> native binaries are added as optionalDependencies. TypeScript 7 is the Go port, and the JS compiler API surface that v6 exposed is the reason the 6.x line exists in parallel.
ts-node@10.9.2 loads that JS compiler API from the typescript peer dependency at runtime. It drives seven entry points here, four of which run in CI (test-all.yml):
npm run setup:flags→scripts/match-server-config.tsnpm run setup:crypto→scripts/generate-crypto.tsnpm run seed:vault:account→scripts/create-account.tsnpm run seed:vault:ciphers→scripts/seeder.sh:70→scripts/vault-seeder.ts
Plus setup:install, setup:flags:ci, and benchmark locally. pretest also runs tsc --incremental -p tests/tsconfig.json, which must still emit into tests-out/ for every spec to run.
Both Build and test jobs are currently red on this PR. If the failure is unrelated (e.g. the bitwarden/clients artifact download), it would be worth confirming a local npm run pretest && npm run setup:crypto succeeds against 7.0.2 before merging; if ts-node cannot consume the native package, pinning typescript to the 6.x line until ts-node is replaced (e.g. with tsx) is the smaller change.
45125a6 to
c2a474f
Compare
This PR contains the following updates:
6.0.3→7.0.2Release Notes
microsoft/TypeScript (typescript)
v7.0.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.