Security Principles Page Is Dead Link for Security Skill - #847
Conversation
Deploying contributing-docs with
|
| Latest commit: |
b665850
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ec10815.contributing-docs.pages.dev |
| Branch Preview URL: | https://docs-security-principles-ind.contributing-docs.pages.dev |
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a single new documentation page, Code Review DetailsNo code findings. PR Metadata Assessment
|
withinfocus
left a comment
There was a problem hiding this comment.
The content is in the individual pages though -- we just need an index page that provides links to all sub-pages.
I was picturing how we do the ADRs page: https://contributing.bitwarden.com/architecture/adr/#adrs With maybe keeping the principles section. |
| @@ -1,16 +1,16 @@ | |||
| # P03 - Limited security for vaults on semi-compromised devices | |||
|
|
|||
| A semi-compromised device is one where malware exists in User Space but has not breached Kernel or | |||
There was a problem hiding this comment.
Reverted — P03 and P04 are back to their original order (byte-identical to main), so this PR is a single new file again.
For context on why they moved: the DocCardList on the new index page excerpts each card description from the page's first block, and on these two pages that is the admonition. Both cards rendered as "This principle applies only to unlocked vaults. Refer to P02 for details" rather than their own principle. That is cosmetic and not worth the churn here — if we want to fix the card text later, a description in the frontmatter does it without touching the prose.
| documentation references directly, as described in | ||
| [the security section's conventions](../index.mdx#references). | ||
|
|
||
| Several principles define the device compromise level they assume. P02 governs locked vaults, while |
There was a problem hiding this comment.
⛏️ Drop this section, in case something drifts and it becomes inaccurate given the duplication.
There was a problem hiding this comment.
Removed this section.
🎟️ Tracking
No tracking. Came up from a conversation in slack in team eng ai channel
📔 Objective
bitwarden-security-context/SKILL.mdhas a broken page. Fixing this to help the model have access to a security principles link within the skill, but also give a high level summary of each of the principles.📸 Screenshots
Before:

After:
