[PM-38792] feat: Enforce Send deletion date via Send Controls policy - #2910
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Re-reviewed the Send Controls Code Review DetailsNo findings at or above the reporting threshold. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## matt/PM-40460-send-controls-restrict-send-type #2910 +/- ##
==================================================================================
- Coverage 79.60% 79.60% -0.01%
==================================================================================
Files 1169 1169
Lines 75224 75261 +37
==================================================================================
+ Hits 59884 59913 +29
- Misses 15340 15348 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4a790d9 to
e6e82db
Compare
| "NewSendCreated" = "Send created"; | ||
| "Custom" = "Custom"; | ||
| "SendDisabledWarning" = "Due to an enterprise policy, you are only able to delete an existing Send."; | ||
| "SendDeletionDateEnforcedByOrganization" = "This date is enforced by your organization"; |
There was a problem hiding this comment.
⛏️ Can't we use the key made from the value? ThisDateIsEnforcedByYourOrganization
There was a problem hiding this comment.
Yep, good catch!
e6e82db to
61dc7db
Compare
61dc7db to
df6fa3f
Compare
…s when editing or removing password
🎟️ Tracking
PM-38792
📔 Objective
Adds enforcement of the new Send Controls policy
deletionHoursoption. When an organization restricts the Send deletion date, a non-owner/non-admin user sees the enforced deletion date pre-selected and locked on the Send add/edit screen, with helper text explaining the restriction. Also adds the previously-missing 14 days deletion option to the menu.📸 Screenshots