[PM-41934] fix: Fix Bank Account behavior and UI bugs

[morganzellers-bw]

🎟️ Tracking

• PM-41934 — Hide Bank Account filter when there are no bank account items
• PM-41936 — Correct Bank Account type dropdown order and remove placeholder
• PM-41937 — Correct Add Item type menu order to match designs
• PM-41935 — Show "Bank account saved" toast after saving a bank account item
• PM-41957 — Show "New folder created" toast when adding a folder from an item's folder dropdown

📔 Objective

Adds a batch of small Bank Account item behavior/UI bug fixes.

📸 Screenshots

Click to reveal

PM-41934 Hide Bank Account

PM-41936 Account type dropdown order

PM-41937 Add item type menu order

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

Reviewed the Bank Account UI/behavior fixes: hiding the Bank Accounts types row when its count is zero, the new BankAccountType.displayOrder and its use as the account type menu options, the blank defaultValueLocalizedName placeholder removal, the BankAccountItemState.accountType default of .custom(.checking), and the CipherType.canCreateCases reorder. Traced the reorder through VaultRepository.getItemTypesUserCanCreate() (which reverses the list) into addVaultItemFloatingActionMenu, and confirmed the resulting upward menu order matches the screenshot. Also traced the new .custom(.checking) default through CipherView.bankAccountItemState(), bankAccountView, and isBankAccountDetailsSectionEmpty — existing items with a missing or unrecognized account type still map to .default and round-trip as nil, and the view screen only renders the bank account section for .bankAccount ciphers. One finding: the in-branch revert of the folder-created toast removes behavior that is already on main.

Code Review Details

• ⚠️ : Revert removes the "New folder created" toast that exists on main (added by PR 2991), regressing PM-41957 for the item folder dropdown path
  • BitwardenShared/UI/Vault/VaultItem/AddEditItem/AddEditItemProcessor.swift:1153

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.87%. Comparing base (9de43d8) to head (4ff45ae).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
+ Coverage   79.60%   81.87%   +2.26%     
==========================================
  Files        1169     1046     -123     
  Lines       75194    67897    -7297     
==========================================
- Hits        59857    55589    -4268     
+ Misses      15337    12308    -3029     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

⚠️ IMPORTANT: This reverts the "New folder created" toast that is already on main, regressing PM-41957 for the item folder dropdown path.

Details and fix

The branch commit 7519d77 ("Revert [PM-41957]...") reverts 116b4b9, but that commit is not part of this branch — it is in the PR's base. The merge base (9de43d8) contains state.toast = Toast(title: Localizations.folderCreated) in folderAdded(_:), so this diff is a net removal of shipped behavior rather than a no-op drop of in-branch work.

PR #2991 ("Show New folder created toast on all folder creation paths", merged 2026-09-01) added exactly these two lines — the processor line and the XCTAssertEqual(subject.state.toast, Toast(title: Localizations.folderCreated)) assertion in AddEditItemProcessorTests.test_folderAdded. VaultListProcessor.swift:839 still sets the toast, so after this merges the vault-list path keeps the toast while adding a folder from an item's folder dropdown silently loses it — the specific path PM-41957 was filed for.

The PR description strikes PM-41957 through, which suggests the intent was to drop that work from this PR, not to remove it from main. Suggest restoring both lines:

func folderAdded(_ folderView: FolderView) {
    state.folder = .custom(folderView)
    state.toast = Toast(title: Localizations.folderCreated)
}

If removing it is intentional (e.g. superseded by a different toast strategy), it would help to say so in the description so the revert is not read as an accidental rebase artifact.