[PM-42022] fix: Drivers License accessibility fixes - #3012
[PM-42022] fix: Drivers License accessibility fixes#3012morganzellers-bw wants to merge 4 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the VoiceOver accessibility changes across Code Review DetailsNo findings. |
97dc5ed to
91603d2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
+ Coverage 79.57% 79.59% +0.01%
==========================================
Files 1169 1169
Lines 75195 75219 +24
==========================================
+ Hits 59838 59868 +30
+ Misses 15357 15351 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
91603d2 to
5ab90ec
Compare
…icense view toggles The View screen's license number visibility toggle used PasswordVisibilityButton's generic "Toggle Visibility" wording because the button never applied its own accessibilityLabel property to the underlying control. Fix the bug in the shared component and wire the Drivers License view to announce the field name.
…icense add/edit toggles The Add/Edit license number visibility toggle announced generic "Password" wording because BitwardenTextField's show/hide button hardcoded that label regardless of field type. Add an opt-in field name parameter and wire the Drivers License number field to announce its own name.
…ly to VoiceOver The View screen's masked license number is rendered as plain Text, which VoiceOver reads as a single word rather than spelling out each character. Add an opt-in flag using the native speechSpellsOutCharacters modifier and enable it for the license number field.
…o icon to VoiceOver The info button was nested inside the toggle's title HStack, so VoiceOver collapsed the whole row into a single unreachable element. Move the button into BitwardenToggle's accessory slot, which keeps it independently reachable, and announce it as an external link.
5ab90ec to
f661821
Compare
🎟️ Tracking
📔 Objective
Adds a batch of VoiceOver accessibility fixes under the Drivers License item type, mirroring the same batch of fixes already shipped for Bank Account in #2985:
The overflow ("more options") menu fix (PM-42026) is stacked on top in #3013, since it grew into a larger shared-component rework and made sense to track as its own PR.
📸 Screenshots