Add set_oblique setter and finalise oblique projection docs - #94
Merged
Conversation
Give oblique a set_oblique(angle, foreshortening) setter alongside set_orthographic and set_perspective, so every mode is selected the same way; it sets an Oblique projection, returns self for chaining, and validates through the type. Present the three projection modes together in the rendering guide, with a three-panel perovskite comparison (orthographic and perspective on the shared view, oblique looking down [100] so the receding axis reads clearly). The changelog and examples now use set_oblique. Also drop an unused import and a dead local in the docs image generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
set_oblique(angle, foreshortening)setter so oblique is selected the same way as the other modes (set_orthographic,set_perspective): it sets anObliqueprojection, returnsselffor chaining, and validates through the type.Presents the three projection modes together in the rendering guide, with a three-panel perovskite comparison (orthographic and perspective on the shared view, oblique looking down [100] so the receding axis reads clearly). The changelog and examples now use
set_oblique.Also drops an unused import and a dead local in the docs image generator.