MB-72535: Cap leaf term searchers per index per search - #2387
Merged
Conversation
|
coverage: 52.363% (+0.04%) from 52.323% — MB-72535 into master |
Likith101
requested review from
CascadingRadium,
Likith101,
Thejas-bhat,
capemox,
maneuvertomars and
steveyen
July 29, 2026 06:28
Likith101
reviewed
Jul 31, 2026
Member
|
@Samsonnyyeet is |
Add MaxTermSearchersKey: count every leaf term searcher and fail the search once the count exceeds the limit. The cap is per leaf index, not global: it spans the whole query tree within a single index, but across an IndexAlias each index is counted independently.
Samsonnyyeet
changed the title
Likith101
approved these changes
Aug 6, 2026
Thejas-bhat
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MaxTermSearchersKey: count every leaf term searcher (at the single choke point newTermSearcherFromReader) and fail the search once the count exceeds the limit.
The cap is per leaf index, not global: within a single index it spans the whole query tree, but across an IndexAlias each index is counted independently, so the effective ceiling scales with the number of indexes.
Unlike DisjunctionMaxClauseCount, which is enforced per fan-out node, this bounds the total across a single index's query tree rather than at any one node.