Skip to content

GT Exit fight mid-palette-change fix. #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nn357 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

GT Exit fight mid-palette-change fix. #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified patches/ips/vanilla_bugfixes.ips
View file
Open in desktop
Binary file not shown.
16 changes: 15 additions & 1 deletion patches/src/vanilla_bugfixes.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,4 +272,18 @@ bootstable:
dw $0040 ; boots - blue booster
dw $0080 ; boots - spark booster

assert pc() <= !bank_82_free_space_end
assert pc() <= !bank_82_free_space_end

;; GT: Exit fight mid-palette-change fix.

; The door transition code assumes the palette counter/timer is 0.
; If the GT fight is exited while GT is changing color, the counter
; can be non-zero, causing the transition to start at the wrong timer
; index. If the index is high enough, this can corrupt the graphics
; during the transition.

; Include the palette counter/timer in the door transition zero-loop
; counter so the transition starts from the correct index.

org $82e1e1 ; (Game state Ah (door transition - setup) ;;;)
ldx #$0104
Loading