Fix secure validation for fork skill submissions - #71
Closed
denial123789 wants to merge 1 commit into
Closed
Conversation
denial123789
force-pushed
the
agent/fix-security-scanner
branch
from
August 15, 2026 13:11
8166ad4 to
22518bf
Compare
Signed-off-by: liyb <lybing315@163.com>
denial123789
force-pushed
the
agent/fix-security-scanner
branch
from
August 15, 2026 13:15
22518bf to
f510976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
git fetch/git worktreeoperations instead of askingactions/checkoutto opt into unsafe checkout underpull_request_target../prdata directory, rather than executing a fork-modified validator.sksidentifier at the end ofscripts/skills-security-scan.mjs.Why
Fork submissions currently stop before validation because
actions/checkoutrejects an untrusted fork checkout in a privilegedpull_request_targetrun. Later steps then obscure the root cause with missing-report errors. Independently, the scanner writes its report and then throws:The new flow keeps executable workflow and validation code on the trusted base revision. Fork content is materialized only as input data; the validator already rejects symlinks and unsafe file types.
Validation
multi-source-search--repo-rootagainst the fork worktree —FAIL=0node scripts/skills-security-scan.mjs— completed with a WARN report and no runtime exceptionnode scripts/validate-skills.mjs— 7 base skill directories validatedgit diff --checkCloses #59.