deps: source zquic from zigstack (release v0.1.2) - #81
Merged
Conversation
Point the zquic dependency at github.com/zigstack/zquic (the canonical org home), matching the exact URL + hash that zig-libp2p uses. Zig deduplicates a diamond dependency only when every consumer pins the identical URL+hash, so sharing the zigstack URL lets a downstream (zeam) that depends on both zig-ethp2p and zig-libp2p resolve a single zquic module instead of two colliding ones. Same content hash as before; no source changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the zquic dependency at
github.com/zigstack/zquic— the canonical org home — matching the exact URL + hash that zig-libp2p uses.Zig deduplicates a diamond dependency only when every consumer pins the identical URL+hash. A downstream (zeam) that depends on both zig-ethp2p and zig-libp2p was getting two separate zquic module instances (
error: file exists in modules 'zquic' and 'zquic0') because the two pinned zquic via different org URLs (zigstack vs ch4r10t33r) despite the same content hash. Sharing the zigstack URL lets them resolve to one module (the same wayzig_varintalready dedupes).Same content hash as before — no source changes.