Linting & Formatting updates - #18
Open
ARK4579 wants to merge 3 commits into
Open
Conversation
added 3 commits
April 17, 2024 18:13
…debase. also setup vscode settings.json file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added
pylintandpyaflinting and formatting settings and formatted codebase. I have also setup vscodesettings.jsonfile.I know these formatting changes might be a lot. I have configure linter and formatter to ignore a lot of rules and can further configure them to follow most of the rules we already have in repo without many changes. but I think we should go with these formatting rules/changes at-least.
P.S. later on we can stop ignoring some of the rules and apply fixes for them instead that require code changes.