add query to the warn_deprecated_quoted_param message - #6110
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_dbname
ssl_prefer
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net> log spname instead of the whole query Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
| if (!warn_once) { | ||
| warn_once = 1; | ||
| warn_deprecated_quoted_param(clnt->sp->spname); | ||
| } |
There was a problem hiding this comment.
Not a huge issue but the previous guarantee pthread_once is atomic. Maybe do this instead to keep this guarantee:
static int warn_once = 0;
if (XCHANGE32(warn_once, 1) == 0) {
warn_deprecated_quoted_param(clnt->sp->spname);
}
3 participants
No description provided.