Skip to content

add check_for_overlap, and do not suppress SQLITE_DDL_MISUSE thrown b… - #6127

Open
rishitha957 wants to merge 1 commit into
bloomberg:mainfrom
rishitha957:sc_deadlock
Open

add check_for_overlap, and do not suppress SQLITE_DDL_MISUSE thrown b…#6127
rishitha957 wants to merge 1 commit into
bloomberg:mainfrom
rishitha957:sc_deadlock

Conversation

@rishitha957

Copy link
Copy Markdown
Contributor

add check_for_overlap, and do not suppress SQLITE_DDL_MISUSE thrown by dml when there's overlap

this pr should fix 2 things

  • detect overlap between (rename t to tnew, create tnew) in same transaction
  • when mixing ddl and dml statements in same transaction, throw SQLITE_DDL_MISUSE instead of (-5 unknown error)

…y dml when there's overlap

Signed-off-by: RKALICHETI1 <RKALICHETI1@bloomberg.net>

clang fix

Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
cdb2jdbc
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
queuedb_rollover_noroll1_generated **quarantined**
cdb2jdbc
analyze **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants