override Implementation-Title - #6129
Open
rishitha957 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>
roborivers
suggested changes
Aug 12, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
SChakravorti21
approved these changes
Aug 13, 2026
SChakravorti21
left a comment
SChakravorti21
left a comment
Contributor
There was a problem hiding this comment.
Let's merge this for now so the existing CI continues to pass, but @hgeraldino I think we need to review how the artifactId and name are set because that currently drives what gets populated in comdb2_clientstats.api_driver_name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
Comdb2ClientInfo.getDriverName()returns project.name and not project.artifactId, ClientInfoIT test expects that