Add manual cache selection for RSPS replays - #84
Merged
Conversation
Khaled431
force-pushed
the
replay-rsps-cache
branch
from
September 3, 2026 04:52
434c9f8 to
02f7cbe
Compare
Khaled431
force-pushed
the
replay-rsps-cache
branch
from
September 3, 2026 05:03
02f7cbe to
30f982e
Compare
Khaled431
marked this pull request as ready for review
September 3, 2026 05:06
Khaled431
force-pushed
the
replay-rsps-cache
branch
from
September 3, 2026 05:26
30f982e to
fceb0f3
Compare
Khaled431
force-pushed
the
replay-rsps-cache
branch
from
September 3, 2026 05:39
fceb0f3 to
4851058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replaying logs, the current behavior is to look up a matching cache in OpenRS2. When that log is not an OSRS recording, there can't be a match found, which invokes a failure prompt.
This PR adds support for manual cache specification, rather than an error, so that the replay can execute. The way that it works is that it opens an explorer on the first run. On future runs, it will have a drop-down that allows you to select the previous run's cache or a new one. On master table mismatch, the non-osrs based runs will provide a warning and ask the user to continue.
Also fixes a bug with
runelite.rsprox.connection=truewhere replays don't open that socket.