chore(deps): migrate jemallocator -> tikv-jemallocator - #5525
Conversation
Migrate from unmaintained jemallocator to tikv-jemallocator, the official successor maintained by TiKV. Closes boa-dev#5516
There was a problem hiding this comment.
🟢 Approval recommended
The dependency rename and allocator references are consistently updated across all reviewed files.
Pull request overview
This pull request migrates Boa from jemallocator to the maintained tikv-jemallocator successor without changing allocator behavior.
Changes:
- Renames workspace and crate dependencies.
- Updates CLI and benchmark allocator references.
- Refreshes
Cargo.lockentries.
File summaries
| File | Description |
|---|---|
core/engine/Cargo.toml |
Updates the benchmark dependency. |
core/engine/benches/full.rs |
Uses the renamed allocator crate. |
cli/src/main.rs |
Uses the TiKV allocator crate. |
cli/Cargo.toml |
Updates the CLI dependency and feature. |
Cargo.toml |
Updates the workspace dependency. |
Cargo.lock |
Replaces the allocator package entries. |
benches/Cargo.toml |
Updates the benchmark dependency. |
benches/benches/scripts.rs |
Uses the renamed allocator crate. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Yes, please bump the version of the dep |
|
Cool, @jedel1043 I've bumped thanks for reviewing! also, any other issues or tasks you'd like me to work on?
|
jedel1043
left a comment
There was a problem hiding this comment.
nope, everything looks good, thanks!
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5525 +/- ##
===========================================
+ Coverage 47.24% 63.10% +15.86%
===========================================
Files 476 536 +60
Lines 46892 60316 +13424
===========================================
+ Hits 22154 38064 +15910
+ Misses 24738 22252 -2486 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Hi @jedel1043,
Migrate from unmaintained
jemallocatortotikv-jemallocator, the official successor maintained by TiKV.Closes #5516.
Rename-only
0.5.4 -> 0.5.4, no behaviour change,cargo check/cargo treeverified.Kept
Cargo.lockminimal for this PR (only the rename) to keep the diff focused. The fullcargo updateto latest compatible patches is not needed for the rename, but should I add it as a consecutive commit in this PR?Also, should I bump
tikv-jemallocatortoa newer 0.6/0.7here? Happy to add that as another consecutive commit in this PR if it is needed.