Skip to content

chore(deps): migrate jemallocator -> tikv-jemallocator - #5525

Merged
jedel1043 merged 2 commits into
boa-dev:mainfrom
Jayesh-Dev21:chore/migrate-tikv-jemallocator
Sep 18, 2026
Merged

jedel1043 merged 2 commits into
boa-dev:mainfrom
Jayesh-Dev21:chore/migrate-tikv-jemallocator

Conversation

@Jayesh-Dev21

Copy link
Copy Markdown
Contributor

Hi @jedel1043,
Migrate from unmaintained jemallocator to tikv-jemallocator, the official successor maintained by TiKV.

Closes #5516.

image
Rename-only 0.5.4 -> 0.5.4, no behaviour change, cargo check/cargo tree verified.

Kept Cargo.lock minimal for this PR (only the rename) to keep the diff focused. The full cargo update to latest compatible patches is not needed for the rename, but should I add it as a consecutive commit in this PR?

Also, should I bump tikv-jemallocator to a newer 0.6/0.7 here? Happy to add that as another consecutive commit in this PR if it is needed.

Migrate from unmaintained jemallocator to tikv-jemallocator,
the official successor maintained by TiKV.

Closes boa-dev#5516
Copilot AI lite review requested due to automatic review settings September 14, 2026 18:25
@Jayesh-Dev21
Jayesh-Dev21 requested a review from a team as a code owner September 14, 2026 18:25
@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Dependencies Pull requests that update a dependency file C-Benchmark Issues and PRs related to the benchmark subsystem. C-CLI Issues and PRs related to the Boa command line interface. and removed Waiting On Review Waiting on reviews from the maintainers labels Sep 14, 2026
@github-actions github-actions Bot added this to the v0.23 milestone Sep 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency rename and allocator references are consistently updated across all reviewed files.

Pull request overview

This pull request migrates Boa from jemallocator to the maintained tikv-jemallocator successor without changing allocator behavior.

Changes:

  • Renames workspace and crate dependencies.
  • Updates CLI and benchmark allocator references.
  • Refreshes Cargo.lock entries.
File summaries
File Description
core/engine/Cargo.toml Updates the benchmark dependency.
core/engine/benches/full.rs Uses the renamed allocator crate.
cli/src/main.rs Uses the TiKV allocator crate.
cli/Cargo.toml Updates the CLI dependency and feature.
Cargo.toml Updates the workspace dependency.
Cargo.lock Replaces the allocator package entries.
benches/Cargo.toml Updates the benchmark dependency.
benches/benches/scripts.rs Uses the renamed allocator crate.
Review details
  • Files reviewed: 7/8 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jedel1043

Copy link
Copy Markdown
Member

Yes, please bump the version of the dep

@jedel1043 jedel1043 added the Waiting On Author Waiting on PR changes from the author label Sep 18, 2026
@Jayesh-Dev21

Jayesh-Dev21 commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Cool, @jedel1043 I've bumped tikv-jemallocator to 0.7 ; ready to merge

thanks for reviewing! also, any other issues or tasks you'd like me to work on?

image

@jedel1043 jedel1043 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, everything looks good, thanks!

@jedel1043
jedel1043 enabled auto-merge September 18, 2026 20:43
@github-actions

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,578 53,578 0
Passed 51,439 51,439 0
Ignored 1,648 1,648 0
Failed 491 491 0
Panics 0 0 0
Conformance 96.01% 96.01% 0.00%

Tested main commit: a93e0b3ff8e917e4e7abb886242655929706ddda
Tested PR commit: dd2fef8d5ef10c90a6c003a6d4c6e873ed302293
Compare commits: a93e0b3...dd2fef8

@jedel1043
jedel1043 added this pull request to the merge queue Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.10%. Comparing base (6ddc2b4) to head (dd2fef8).
⚠️ Report is 1058 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5525       +/-   ##
===========================================
+ Coverage   47.24%   63.10%   +15.86%     
===========================================
  Files         476      536       +60     
  Lines       46892    60316    +13424     
===========================================
+ Hits        22154    38064    +15910     
+ Misses      24738    22252     -2486     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into boa-dev:main with commit 3046147 Sep 18, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Benchmark Issues and PRs related to the benchmark subsystem. C-CLI Issues and PRs related to the Boa command line interface. C-Dependencies Pull requests that update a dependency file Waiting On Author Waiting on PR changes from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to tikv-jemallocator

3 participants