Skip to content

Update create_date_time_format - #5540

Open
Vellumic wants to merge 15 commits into
boa-dev:mainfrom
Vellumic:refactor/create-date-time-format
Open

Vellumic wants to merge 15 commits into
boa-dev:mainfrom
Vellumic:refactor/create-date-time-format

Conversation

@Vellumic

@Vellumic Vellumic commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

This Pull Request is a preparation work before updating the logic according to Temporal proposal.

It changes the following:

  • Change function signature
  • Update spec comments
  • Refactor IntlOptions construction
  • Clean up code in some places
  • Add an extra validation in step 28

@Vellumic
Vellumic requested review from a team, jedel1043 and nekevss as code owners September 27, 2026 16:00
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Sep 27, 2026
@github-actions github-actions Bot added this to the v0.23 milestone Sep 27, 2026
@github-actions github-actions Bot added C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation labels Sep 27, 2026
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,578 53,578 0
Passed 51,439 51,436 -3
Ignored 1,648 1,648 0
Failed 491 494 +3
Panics 0 0 0
Conformance 96.01% 96.00% -0.01%
Fixed tests (1):
test/intl402/DateTimeFormat/prototype/resolvedOptions/calendar.js (previously Failed)
Broken tests (4):
test/intl402/DateTimeFormat/constructor-options-calendar-future-fallback.js (previously Passed)
test/intl402/DateTimeFormat/constructor-options-order.js (previously Passed)
test/intl402/DateTimeFormat/constructor-calendar-numberingSystem-order.js (previously Passed)
test/intl402/DateTimeFormat/prototype/resolvedOptions/resolved-calendar-unicode-extensions-and-options.js (previously Passed)

Tested main commit: 39cd11214ecb366200157dab96b3919e61e9a391
Tested PR commit: b365a2c949fbe54cd10cbf78b6d1594cac023a29
Compare commits: 39cd112...b365a2c

@Vellumic
Vellumic force-pushed the refactor/create-date-time-format branch from 5396c45 to c2581d3 Compare September 29, 2026 00:18
@Vellumic
Vellumic force-pushed the refactor/create-date-time-format branch from c2581d3 to b365a2c Compare September 29, 2026 01:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant