fix(translations): add missing general.phrase.none key - #3796
Merged
Conversation
The key is referenced by both taxonomy link helpers but existed in no catalogue, so it leaked as the raw string "general.phrase.none" to public visitors on any record with an empty taxonomy group. ContentExtension::getTaxonomies() pre-seeds every taxonomy declared on the ContentType with an empty array, so the for/else fallback is reached on default config whenever a record has no terms for a given type. Added to all 16 message catalogues with unit id OPxagAY, matching the id Symfony's XliffFileDumper generates for this source. Targets use forms that are invariant or read correctly standalone, since the live consumer (public/theme/skeleton/partials/_sub_taxonomylinks.twig) emits no label at all in the empty case and the bundled helper emits a singular label of arbitrary gender.
bobvandevijver
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up of #3753
Changes
general.phrase.noneis used by both taxonomy link helpers but existed in no catalogue, so it rendered as the literal stringgeneral.phrase.noneon the frontend skeleton theme.Translations
Testing
En
Nl
Cs