perf(walk): flatten recursion via rayon::scope, drop -S stack-size knob - #620
Merged
Merged
Conversation
bootandy
force-pushed
the
walker-scope
branch
3 times, most recently
from
September 9, 2026 21:48
83279bf to
8c97480
Compare
Assisted-by: Claude Opus 4.7 (code generation, refactoring, code review)
bootandy
force-pushed
the
walker-scope
branch
from
September 9, 2026 21:55
8c97480 to
68033f0
Compare
Owner
Author
|
This does have a performance impact (aprox double) so is worth doing. I hope the old issue with low memory on small machines is now fixed as we don't need a large stack. |
bootandy
marked this pull request as ready for review
September 9, 2026 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Opus 4.7 (code generation, refactoring, code review)