Drop integrity filtering from working task workflows - #67
Merged
Conversation
Remove min-integrity filtering from drafter.md and fix.md to allow these workflows to process issues and PRs from all contributors, not just those with approved integrity status. This enables generic "issue to PR" workflows to work without filtering by contributor trust level. The security gate is now handled by the reviewer agent rather than integrity filtering at input time. Fixes #66 Assisted-by: AI
Contributor
Author
There was a problem hiding this comment.
Threat detection produced a warning for this pull request output.
These changes need to be scrutinized before merge and only merged after a careful manual review.
- Detection reason:
threat_detected - Review workflow run logs: https://github.com/bootc-dev/gh-agentic-workflows/actions/runs/33073585367
Contributor
Author
There was a problem hiding this comment.
Review Complete ✓
I've reviewed this PR for correctness, security, quality, and adherence to repository conventions.
What I checked:
Architecture & Security:
- ✓ Correctly removes hardcoded integrity filtering from
drafter.mdandfix.md - ✓ Sound security model: shifts from input-level contributor filtering to code-review-level security gate
- ✓ Review workflow (
review.md) maintains its role as the security gate - ✓ Dynamic integrity determination now handled by
determine-automatic-lockdownstep
Code Changes:
- ✓ Lockfiles properly recompiled with
gh aw compile - ✓ Metadata hashes updated correctly (frontmatter changes reflected)
- ✓ MCP gateway configuration correctly migrated to use environment variables
- ✓ Removed now-unnecessary
parse-guard-varsstep
Validation:
- ✓ All 5 workflows compiled without warnings (per PR description)
- ✓ Changes are minimal and focused on the stated objective
- ✓ Addresses issue #66 as intended
The architectural change is well-reasoned: for generic "issue to PR" workflows, having the reviewer agent examine actual code changes is indeed a more appropriate security gate than filtering contributors upfront. This PR implements that change correctly.
Ready to merge.
cgwalters
enabled auto-merge (squash)
August 27, 2026 13:08
cgwalters
approved these changes
Aug 27, 2026
cgwalters
disabled auto-merge
August 27, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.
Details
Potential security threats were detected in the agent output.
Review the workflow run logs for details.
Fixes #66
This PR removes
min-integrityfiltering fromdrafter.mdandfix.mdworkflows to allow these workflows to process issues and PRs from all contributors, not just those with approved integrity status.Changes
min-integrity: approvedsetting fromdrafter.mdandfix.mdtrusted-usersconfiguration from both workflowsRationale
As discussed in #66, for generic "issue to PR" workflows, integrity filtering at the input level is not the right security gate. The security review is better handled by the reviewer agent that examines the code changes rather than filtering contributors upfront.
This change enables the drafter and fix workflows to work with contributions from all users regardless of their trust level in the repository.
Validation
gh aw compiletools.githubconfiguration sectionAssisted-by: AI