regenerate: drop the ast_typefactory_bind.h include and needStringCast - #46
Merged
Merged
Conversation
daScript deletes that header: the cast_arg specializations it carried move next to the generic cast_arg in simulate/interop.h, and the typeFactory callback fallback next to the primary typeFactory in ast/ast_typedecl.h. The binder no longer emits the include. The wrap had to move because the call node is now keyed on the signature, so one instantiation is shared by binds from many TUs, and only the TUs including this header saw the null-string conversion. Needs GaijinEntertainment/daScript#3921
aleksisch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the generated bindings carry that GaijinEntertainment/daScript#3921 removes:
#include "daScript/ast/ast_typefactory_bind.h"— that header is deleted there. Itscast_argspecializations move next to the genericcast_arginsimulate/interop.h, and thetypeFactorycallback fallback next to the primarytypeFactoryinast/ast_typedecl.h. The binder no longer emits the include, so this is what regenerating produces.fn->needStringCast = truein the module fixup — daScript now substitutes""for a null daslang string on every bind, in the interpreter, AOT and JIT alike, so the flag is gone and the scan that fed it has nothing left to do.Please merge before daScript#3921 — its
fatmanandwasmboyjobs clone this repo's default branch, so they fail on both counts until this lands.