This repository was archived by the owner on Aug 17, 2026. It is now read-only.
Superbuild: static half only — drop the ADD_MODULE_LIB shared twin - #65
Merged
Conversation
Found by the daslang fat-man gate on its first real (daslang_static) link: the superbuild branch built both halves of ADD_MODULE_LIB, but the shared twin of an imgui-family module cannot link on Windows (no IMGUI_API dllexport matrix across the pair, no glfw import lib) — and nothing ever loads it: in a superbuild the DLL flavor comes from this module's own standalone build (daspkg). Static half only, matching what an embedded host and daslang_static actually consume. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the superbuild (embedded) CMake integration for dasVulkan to only build/link the static module library, removing the previously-created shared “twin” target from the superbuild path. This aligns dasVulkan with the other imgui-family externals that don’t build usable shared twins in a superbuild context, while keeping the standalone shared-module build flow intact.
Changes:
- Replaced
ADD_MODULE_LIB(libDasModuleVulkan dasModuleVulkan …)with a static-onlyADD_DAS_STATIC_MODULE_LIB(libDasModuleVulkan …)in the superbuild branch. - Removed superbuild-only configuration/link steps that referenced the shared twin target (
dasModuleVulkan) while preserving static target setup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the daslang fat-man gate: the
ADD_MODULE_LIBshared twin is dead weight in a superbuild — nothing loads it (the DLL flavor comes from this module's own standalone build), and the imgui-family externals can't even link theirs without a dllexport matrix, so the sweep drops the twins uniformly. dasVulkan's twin happened to link (self-contained volk), so this is consistency + not building a target nobody consumes. Same fix as borisbat/dasImgui#219 / borisbat/dasImguiImplot#26 / borisbat/dasImguiNodeEditor#37.Validated: full fat-man link + smoke on Windows (
daslang_static, all five externals,rc=0); standalone flow untouched.🤖 Generated with Claude Code