feat: Admin MCP 게이트웨이(mcp) 추가 - #374
Open
Whale0928 wants to merge 3 commits into
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp/추가/mcp/*백엔드 API 없음)mcp(bottlenote-접두사 없음)Changes
mcp/: Node 22 + TypeScript MCP 서버 스캐폴드bottlenote_whisky_search,bottlenote_whisky_get(기존/alcohols매핑)linux/amd64,linux/arm64).gitignore강화 (node_modules, .env, sops, kubeconfig, credentials 제외)environment-variables서브모듈은 포함하지 않음mcp/docs/PRINCIPLES.mdisError, description truncate, correlation 전파, graceful shutdown, serverinstructionsAuthentication (현재 v0.1)
Authorization: Bearer bn_agent_*만POST /auth/agent로 Admin JWT 교환 후 API 호출클라이언트 설정 예
{ "mcpServers": { "bottlenote-admin": { "url": "https://mcp.bottlenote.com/mcp", "headers": { "Authorization": "Bearer bn_agent_REPLACE" } } } }이후 후보 (미구현)
백엔드 방화벽 / 개발 서버 방향 (합의 메모)
완전 잠금은 네트워크 격리 + 호출자 신원이 CORS보다 우선이다.
INTERNAL_TOKEN강제는 prod(또는 staging) 플래그로만 켜고, dev에서는 끄는 것을 권장Security / gitignore
.env.example만 포함 (placeholder).BOTTLENOTE_AGENT_KEY는 local smoke 전용, production 기동 시 설정 시 실패POST /auth/agent,GET /alcohols,GET /alcohols/{id}(src/policy/allowlist.ts)Related
Test plan
node_modules/.env/ sops / 실제 키 없음cd mcp && npm install && npm run typecheckNODE_ENV=production+BOTTLENOTE_AGENT_KEY설정 시 기동 실패