First version for support on AMD GPU via HIP backend - #3496
Open
jonycastagna wants to merge 5 commits into
Open
jonycastagna wants to merge 5 commits into
jonycastagna wants to merge 5 commits into
Conversation
ZedThree
approved these changes
Sep 18, 2026
ZedThree
left a comment
ZedThree
left a comment
Member
There was a problem hiding this comment.
Looks good, I've got some questions but they might not be blockers
Author
|
Hi @ZedThree, I just added some comments above and merged latest from "next" but seems some checks were not succesful. Do you know what I am doing wrong? Thanks! |
Member
|
The failing test is unrelated |
Author
|
Ok, thanks! I see now is all good |
Member
|
@jonycastagna Is this ready to merge? You mentioned some other work -- is that a second PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added HIP directive for offloading on AMD GPU via RAJA and binary expression backend