Skip to content

[perf] Optionally skip flatbuffer verification - #728

Closed
atuchin-m wants to merge 1 commit into
masterfrom
optionally-skip-flatbuffer-verification
Closed

atuchin-m wants to merge 1 commit into
masterfrom
optionally-skip-flatbuffer-verification

Conversation

@atuchin-m

@atuchin-m atuchin-m commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

The idea is to provide ability to skip flatbuffer verification for Brave Browser startup in certain scenarios:

  • when we load/create a DAT file we get a token identifying the current DAT file + the engine version
  • the token is stored to local_state;
  • next startup we call deserialize_with_token. If the token matches it's safe to skip verification.

@atuchin-m atuchin-m self-assigned this Sep 15, 2026

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Details
Benchmark suite Current: df6aea3 Previous: 1c0740d Ratio
rule-match-browserlike/brave-list 1899137850 ns/iter (± 6365514) 1924967612 ns/iter (± 7805929) 0.99
rule-match-first-request/brave-list 1368668 ns/iter (± 6149) 1345618 ns/iter (± 43788) 1.02
blocker_new/brave-list 109988922 ns/iter (± 179187) 111587961 ns/iter (± 336549) 0.99
blocker_new/brave-list-deserialize 29936696 ns/iter (± 97315) 31531323 ns/iter (± 2045870) 0.95
memory-usage-final/brave-list-initial 9671732 B/iter (± 0) 9671732 B/iter (± 0) 1
memory-usage-final/brave-list-1000-requests 3215263 B/iter (± 0) 3215263 B/iter (± 0) 1
memory-usage-max/brave-list-initial/max 32237425 B/iter (± 0) 32237425 B/iter (± 0) 1
memory-usage-alloc-count/brave-list-initial/alloc-count 287123 allocs/iter (± 0) 287123 allocs/iter (± 0) 1
memory-usage-alloc-count/brave-list-1000-requests/alloc-count 81427 allocs/iter (± 0) 81427 allocs/iter (± 0) 1
url_cosmetic_resources/brave-list 186540 ns/iter (± 1137) 187013 ns/iter (± 766) 1.00
cosmetic-class-id-match/brave-list 3200624 ns/iter (± 827221) 3336389 ns/iter (± 836749) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.

Benchmark suite Current: e605305 Previous: 1c0740d Ratio
blocker_new/brave-list-deserialize 37949562 ns/iter (± 2502514) 31531323 ns/iter (± 2045870) 1.20

This comment was automatically generated by workflow using github-action-benchmark.

@atuchin-m
atuchin-m force-pushed the optionally-skip-flatbuffer-verification branch from e605305 to df6aea3 Compare September 15, 2026 21:11
@atuchin-m
atuchin-m marked this pull request as ready for review September 15, 2026 21:22
@atuchin-m

Copy link
Copy Markdown
Collaborator Author

replaced by #730

@atuchin-m atuchin-m closed this Sep 24, 2026
@atuchin-m
atuchin-m deleted the optionally-skip-flatbuffer-verification branch September 24, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant