Conversation
There was a problem hiding this comment.
Rust Benchmark
Details
| Benchmark suite | Current: df6aea3 | Previous: 1c0740d | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1899137850 ns/iter (± 6365514) |
1924967612 ns/iter (± 7805929) |
0.99 |
rule-match-first-request/brave-list |
1368668 ns/iter (± 6149) |
1345618 ns/iter (± 43788) |
1.02 |
blocker_new/brave-list |
109988922 ns/iter (± 179187) |
111587961 ns/iter (± 336549) |
0.99 |
blocker_new/brave-list-deserialize |
29936696 ns/iter (± 97315) |
31531323 ns/iter (± 2045870) |
0.95 |
memory-usage-final/brave-list-initial |
9671732 B/iter (± 0) |
9671732 B/iter (± 0) |
1 |
memory-usage-final/brave-list-1000-requests |
3215263 B/iter (± 0) |
3215263 B/iter (± 0) |
1 |
memory-usage-max/brave-list-initial/max |
32237425 B/iter (± 0) |
32237425 B/iter (± 0) |
1 |
memory-usage-alloc-count/brave-list-initial/alloc-count |
287123 allocs/iter (± 0) |
287123 allocs/iter (± 0) |
1 |
memory-usage-alloc-count/brave-list-1000-requests/alloc-count |
81427 allocs/iter (± 0) |
81427 allocs/iter (± 0) |
1 |
url_cosmetic_resources/brave-list |
186540 ns/iter (± 1137) |
187013 ns/iter (± 766) |
1.00 |
cosmetic-class-id-match/brave-list |
3200624 ns/iter (± 827221) |
3336389 ns/iter (± 836749) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: e605305 | Previous: 1c0740d | Ratio |
|---|---|---|---|
blocker_new/brave-list-deserialize |
37949562 ns/iter (± 2502514) |
31531323 ns/iter (± 2045870) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
optionally-skip-flatbuffer-verification
branch
from
September 15, 2026 21:11
e605305 to
df6aea3
Compare
atuchin-m
marked this pull request as ready for review
September 15, 2026 21:22
Collaborator
Author
|
replaced by #730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to provide ability to skip flatbuffer verification for Brave Browser startup in certain scenarios:
deserialize_with_token. If the token matches it's safe to skip verification.