Skip to content

Fix potential crash on bad clipboard item mime type #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apex2504 merged 1 commit into from
Aug 28, 2026
Merged

Fix potential crash on bad clipboard item mime type #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions app/src/main/java/moe/apex/breadboard/saucenao/ReverseSearchScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,24 +205,28 @@ fun ReverseSearchScreen(
clipboard.nativeClipboard.primaryClip?.getItemAt(
0
)

if (clipboardItem != null) {
val uri = clipboardItem.uri
val mimeType = uri?.let {
val mimeType =
clipboardItem?.uri?.let {
context.contentResolver.getType(it)
}

if (mimeType?.startsWith("image/") == true) {
selectedFileUri = uri
} else {
if (mimeType?.startsWith("image/") == true) {
selectedFileUri = clipboardItem.uri
} else {
val clipboardText =
clipboardItem?.text?.toString()?.trim()?.takeIf {
it.isNotEmpty()
}

if (clipboardText != null) {
/* onValueChange does not trigger when you mutate
imageUrl via code, so we still have to reset
selectedFileUri here. */
selectedFileUri = null
imageUrl = clipboardItem.text.toString()
imageUrl = clipboardText
} else {
showToast(context, "Nothing on the clipboard")
}
} else {
showToast(context, "Nothing on the clipboard")
}
}
}
Expand Down
Loading