Skip to content

ci(nixos): write the manifest from the PR's base, not the default branch #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrosseel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(nixos): write the manifest from the PR's base, not the default branch #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/nixos-pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,18 @@ jobs:
group: manifest-write
cancel-in-progress: false
steps:
# Check out the PR's BASE branch explicitly. A bare checkout under
# pull_request_target lands on the repository's default branch, which
# may carry this workflow (so the event fires) without carrying the
# scripts below -- the job then dies after a successful build, leaving
# an image in Attic that no device can reach because the manifest was
# never written. The base branch is the branch this workflow file itself
# came from, so the scripts are always beside it, and it stays
# maintainer-controlled: never check out the PR head here, which would
# run contributor code with contents:write and the Attic token.
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.base.ref }}

- name: Update generated manifest branch
env:
Expand Down
Loading