Skip to content

fix consumer group rewrite - #4

Merged
bubunyo merged 2 commits into
mainfrom
bug/prefix-in-consumer-group-blob
Jun 13, 2026
Merged

fix consumer group rewrite#4
bubunyo merged 2 commits into
mainfrom
bug/prefix-in-consumer-group-blob

Conversation

@bubunyo

@bubunyo bubunyo commented Jun 13, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes consumer group topic rewriting by decoding and rewriting Kafka consumer group member blobs so that group subscriptions/assignments are rewritten consistently across JoinGroup, SyncGroup, and DescribeGroups flows.

Changes:

  • Decode/encode consumer JoinGroup protocol metadata to prefix subscribed topics on requests and strip them for the leader on responses.
  • Decode/encode consumer SyncGroup member assignments to prefix topics on requests and strip them in responses back to members.
  • Extend DescribeGroupsResponseOut to also strip prefixed topic names inside member subscription / assignment blobs; add focused unit tests for these cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
rewrite/groups.go Adds consumer-group blob decoding helpers and applies topic rewriting to JoinGroup/SyncGroup and DescribeGroups member blobs.
rewrite/groups_test.go Adds helpers + new tests validating topic rewriting/stripping behavior for member metadata/assignments and non-consumer passthrough.
proxy/rewrite_groups.go Ensures JoinGroup/SyncGroup responses are post-processed so clients see client-space topics in leader/member blobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread proxy/rewrite_groups.go
@bubunyo
bubunyo merged commit f904d5c into main Jun 13, 2026
9 checks passed
@bubunyo
bubunyo deleted the bug/prefix-in-consumer-group-blob branch June 13, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants