This repository was archived by the owner on Aug 24, 2026. It is now read-only.
Avoid GitHub Actions errors when run URL fields are missing - #292
Merged
Conversation
GitHub Actions detection only requires GITHUB_RUN_NUMBER, so the repository or run ID can be absent when CI metadata is collected. Avoid passing those nil values to File.join and return a nil run URL instead, matching the existing behavior for unavailable CI URLs. Cover each missing environment variable independently to prevent the TypeError from regressing. Amp-Thread-ID: https://ampcode.com/threads/T-01a0338e-1aac-70df-b672-9eb6ef2afcd8 Co-authored-by: Amp <amp@ampcode.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
pda
added a commit
to buildkite/bktest
that referenced
this pull request
Aug 24, 2026
…ix-missing-github-actions-url Avoid GitHub Actions errors when run URL fields are missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When GitHub Actions is detected from
GITHUB_RUN_NUMBERbutGITHUB_REPOSITORYorGITHUB_RUN_IDis absent, the collector passesniltoFile.joinand raises aTypeErrorwhile gathering CI metadata.What
Build the run URL only when both fields are available; otherwise return a nil URL, consistent with unavailable URLs from other CI providers. Regression tests cover each missing field independently.
Fixes #282