fix(registry): safeguard instanceof File checks in upload component and examples - #152
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Safeguard the
instanceof Filechecks in the shadcn upload registry component and its examples. This prevents name clashes and runtime errors ifFileis imported as an icon package (e.g.lucide-react) within the same file or scope.Key Changes
Docs / Web (
apps/web)apps/web/registry/shadcn/fields/upload.tsxto guard the globalFilecheck withtypeof window !== "undefined" && item instanceof window.File.gallery-upload-form.tsx,document-upload-form.tsx, andprofile-upload-form.tsxexamples.apps/web/public/r/usingnpx shadcn build.Type of change
feat(New feature)fix(Bug fix)docs(Documentation changes)refactor(Refactoring code without changing behavior)test(Adding or updating tests)chore(Maintenance, CI/CD, or Ops-related changes)Related Issues