fix(android): open attachments directly with default viewer app#33
Open
arnauda-gh wants to merge 1 commit into
Open
fix(android): open attachments directly with default viewer app#33arnauda-gh wants to merge 1 commit into
arnauda-gh wants to merge 1 commit into
Conversation
Fixes bulwarkmail#32. On Android, Sharing.shareAsync triggers Intent.ACTION_SEND (Share sheet). Updated shareAttachment to convert the file URI to a content URI and launch android.intent.action.VIEW via expo-intent-launcher, with fallback to shareAsync if no viewer application is installed for the MIME type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Summary
Fixes an issue where tapping an email attachment (or file in Files view) on Android opened the system Share sheet ("Partager avec...") instead of opening the file directly in a default viewer application (such as PDF Viewer, Gallery, Video Player, or Document Viewer).
Solution
shareAttachmentinsrc/lib/email-export.tsto convert the downloaded file's URI to acontent://URI usingFileSystemLegacy.getContentUriAsyncon Android.android.intent.action.VIEWviaexpo-intent-launcherwithFLAG_GRANT_READ_URI_PERMISSION.Sharing.shareAsyncif no application is installed on the device for the given file format.!! AI WARNING !! : This PR was generated and created by AI. It has been tested on my own use case and seems to work. However have a deep look about the generated code.