fix(ErrorBoundary): reset when the thrown value is null - #247
Merged
Conversation
|
@hovelopin is attempting to deploy a commit to the Brian Vaughn's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
react-error-boundary@6.1.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ErrorBoundarycan't be reset — neither viaresetErrorBoundary()nor viaresetKeys— when the thrown value isnull. Once the fallback is shown it stays there.Why
Both reset paths check
error !== nullto decide whether the boundary is currently active:When null is thrown, getDerivedStateFromError(null) produces { didCatch: true, error: null }, so both guards fail and onReset / setState(initialState) never run. useErrorBoundary().showBoundary(null) followed by resetBoundary() hits the same path.
Only null is affected — the comparison is strict, so undefined, 0, "" etc. reset correctly.
How
The existing "should support thrown null or undefined values" test only covered rendering and onError, which is why this slipped through.