Skip to content

Replace Deprecated substr with substring in Highlighter.js - #114

Open
baibhavx wants to merge 1 commit into
bvaughn:masterfrom
baibhavx:main
Open

Replace Deprecated substr with substring in Highlighter.js#114
baibhavx wants to merge 1 commit into
bvaughn:masterfrom
baibhavx:main

Conversation

@baibhavx

@baibhavx baibhavx commented Nov 22, 2023

Copy link
Copy Markdown

Summary

This pull request revises Highlighter.js by substituting the outdated substr method with substring.

  • substr is no longer recommended and may have been removed from relevant web standards​​.
image
  • substring is part of the ECMAScript standard and is advised for consistent, future-proof code​​.
image

Tests

  • Existing tests continue to pass

@baibhavx

Copy link
Copy Markdown
Author

Hi @sergei-startsev,
I noticed your recent activity in the repo and wanted to gently bump this PR for your consideration. Please let me know if there's anything I can do to help move this forward. I’m happy to address any feedback or make additional changes if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant