Print params/results of imports - #2654
Merged
alexcrichton merged 1 commit intoSep 11, 2026
Merged
Conversation
This commit is a small change to the `wasmprinter` logic to print `(param ...)` and `(result ...)` for function imports instead of only printing `(type N)`. This helps improve debuggability-at-a-glance since there's no need to cross-reference types, and this is additionally done in preparation for a spec test suite update where this'll be necessary to pass all tests in the extended-name-section proposal. This has a very large fallout in golden outputs for this repository, hence the very large diff. The only source code change is `crates/wasmprinter/src/lib.rs`, however.
pchickey
approved these changes
Sep 11, 2026
pchickey
left a comment
pchickey
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement to readability, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a small change to the
wasmprinterlogic to print(param ...)and(result ...)for function imports instead of only printing(type N). This helps improve debuggability-at-a-glance since there's no need to cross-reference types, and this is additionally done in preparation for a spec test suite update where this'll be necessary to pass all tests in the extended-name-section proposal.This has a very large fallout in golden outputs for this repository, hence the very large diff. The only source code change is
crates/wasmprinter/src/lib.rs, however.