fix(d): Fix crashes with large component type embeddings - #1704
Merged
alexcrichton merged 1 commit intoSep 8, 2026
Merged
Conversation
Contributor
Author
alexcrichton
approved these changes
Sep 8, 2026
Merged
via the queue into
bytecodealliance:main
with commit Sep 8, 2026
2c40116
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when trying to compile generated D bindings against sufficiently large components, there ends up being a stack overflow (or so it seems) in the compiler due to the potentially MASSIVE tree of concatenation expressions used to join the possibly thousands of lines of strings together to form the LLVM IR for the component type section.
Line breaks are needed to keep editors from choking trying to process (e.g. split, syntax highlight, etc.) what would an absurdly long line.
To fix this issue, the raw bytes of the encoded component type are instead embedded as a hex-string (which allows whitespace freely within without it affecting the final contents), and is transformed on the D side at compile time into the string that needs to be embedded into the IR.