fix(merger): use sort_by_key to satisfy clippy::unnecessary_sort_by - #12
Open
jenish-25 wants to merge 1 commit into
Open
fix(merger): use sort_by_key to satisfy clippy::unnecessary_sort_by#12jenish-25 wants to merge 1 commit into
jenish-25 wants to merge 1 commit into
Conversation
Nightly clippy flags the sort_by comparator closures in the merger actors under -D warnings, breaking make clippy in CI. Replace them with the equivalent sort_by_key (+ Reverse for the descending cases).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make clippyis currently failing in CI (onmainand every PR). Clippy runs on nightly with-D warnings, and theclippy::unnecessary_sort_bylint now errors on thesort_bycomparator closures in the merger actors.This replaces them with the equivalent
sort_by_key(usingstd::cmp::Reversefor the descending cases), which is clippy's own machine-applicable suggestion and preserves ordering behavior.Changes
swappath_merger_actor.rs— 2 sorts (one lib, one test)diffpath_merger_actor.rs— 1 sortsamepath_merger_actor.rs— 1 sortVerification
cargo clippy -p kabu-strategy-merger --all-features --all-targets -- -D warnings— cleancargo test -p kabu-strategy-merger --lib— passes (test_sortconfirms ordering is unchanged)cargo fmt— clean