Skip to content

Launch calkit run as process group and kill group in post step #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rebeccamccabe wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Launch calkit run as process group and kill group in post step #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,21 @@ runs:
CALKIT_TOKEN: ${{ inputs.dvc_token || steps.get-calkit-token.outputs.calkit-token }}
CALKIT_DVC_TOKEN: ${{ inputs.dvc_token || steps.get-calkit-token.outputs.calkit-token }}

- run: calkit run ${{ inputs.run_args }}
- name: Run Calkit in isolated process group
shell: bash
run: |
set -euo pipefail

# Launch calkit in a new session/process group
setsid bash -lc 'calkit run ${{ inputs.run_args }}' &
PID=$!

# PGID of the session leader is normally its PID
PGID=$(ps -o pgid= "$PID" | tr -d ' ')

echo "CALKIT_PGID=$PGID" >> "$GITHUB_STATE"
echo "Started calkit PID=$PID PGID=$PGID"
wait "$PID"

- run: calkit save -am "Run pipeline"
if: ${{ inputs.save == 'true' }}
Expand All @@ -347,3 +360,17 @@ runs:
path: .dvc/cache
key: >-
${{ runner.os }}-dvc-cache-${{ github.head_ref || github.ref_name }}-${{ github.sha }}

post:
shell: bash
run: |
set +e

if [ -n "${STATE_CALKIT_PGID:-}" ]; then
PGID="$STATE_CALKIT_PGID"
echo "Cleaning up process group $PGID"

kill -TERM -- -"${PGID}" 2>/dev/null || true
sleep 10
kill -KILL -- -"${PGID}" 2>/dev/null || true
fi
Loading