docs: sync the rspack 2 design doc with review-round changes#1405
Merged
Conversation
The delegated ModuleFederationPluginV1 never resolves @module-federation/runtime-tools under either rspack major; only the enhanced MF 1.5 plugin does, and it carries its own install error. Verified empirically and in the 1.7.12/2.1.2 sources (details on #1400).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
…esign doc - getRspackCacheConfig -> getRspackCacheConfigs: collects both cache locations so --reset-cache clears every candidate directory - legacy-cache warning stays silent when the same config already sets a top-level persistent cache - the manual refresh loader rule self-excludes the vendored runtime files
dannyhw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
agent_context/rspackv2-jul2026/design.mdwith the changes that came out of the stack's review round:ModuleFederationPluginV1needs a resolvability pre-check for@module-federation/runtime-toolsunder Rspack 2. Review of feat: check module federation runtime-tools availability under rspack 2 #1400 disproved the premise: the delegated V1 plugin never uses that package under either major — only the enhanced MF 1.5 plugin (container.ModuleFederationPlugin) resolves it, and that plugin raises its own actionable install error. Verified empirically (clean MFv1 build + container execution under@rspack/core@2.1.2with the package absent) and in the 1.7.12/2.1.2 sources; full evidence in the feat: check module federation runtime-tools availability under rspack 2 #1400 review thread. feat: check module federation runtime-tools availability under rspack 2 #1400 is closed unmerged.getRspackCacheConfig→getRspackCacheConfigs, which collects both the legacy and top-level locations so--reset-cacheclears every candidate directory; the legacy-config warning (feat: warn about legacy experiments.cache config under rspack 2 #1399) stays silent when the same config already sets a top-level persistent cache.Docs only, no code changes.