Skip to content

It's now possible to delete a service that is not connected to a Load Balancer #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coredumperror wants to merge 1 commit into
base: master
Choose a base branch
from
Open

It's now possible to delete a service that is not connected to a Load Balancer #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deployfish/core/models/elbv2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,11 @@ def __get_rules_for_target_group(

"""
tg = TargetGroup.objects.get(target_group_arn)
load_balancer_pk = tg.data["LoadBalancerArns"][0]
try:
load_balancer_pk = tg.data["LoadBalancerArns"][0]
except IndexError:
# This target group is not attached to any load balancers.
return []
rule_objects = self.__get_rules_for_load_balancer(load_balancer_pk)
matched_rules = []
for obj in rule_objects:
Expand Down
Loading