WIP: e2e-tests: share common first steps via VM checkpoints - #1714
Draft
adombeck wants to merge 4 commits into
Draft
WIP: e2e-tests: share common first steps via VM checkpoints#1714adombeck wants to merge 4 commits into
adombeck wants to merge 4 commits into
Conversation
adombeck
added
the
e2e-tests
adombeck
force-pushed
the
UDENG-10153-e2e-test-snapshots
branch
from
July 9, 2026 15:46
df05c8b to
3cdfa4b
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When a test's setup finds that the shared checkpoint it depends on previously failed (or failed concurrently), the test itself cannot meaningfully run. Reporting it as FAIL conflates a genuine test failure with a dependency problem. Tag the test with `checkpoint-failed` before raising in the two Checkpoint.setup_checkpoint paths that surface a prior failure (the "previously failed" and "concurrent failure" cases). The listener then rewrites any FAIL result that carries this tag to NOT RUN in end_test, so those tests are visually and statistically distinct from both genuine failures and broker-not-applicable skips. The NOT RUN case is also added to the listener's status-colour table, and the fixed-width :4 format spec on the status string is dropped so that "NOT RUN" aligns correctly alongside the shorter status labels. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When Journal.Start Receiving Journal connects to the VM via TCP (port 55000), a virsh memory snapshot taken while that connection is alive captures the TCP state as ESTABLISHED. The first test that restores the checkpoint gets a VM whose TCP stack still considers the old socat connection open; new socat connections are refused until the VM's TCP stack times the stale entry out (~60 s). Fix this by stopping the journal and VNC recording before calling Snapshot.Create, so the checkpoint snapshot is taken with no active connections on port 55000. Journal and recording are restarted immediately after the snapshot so the creator test's body still has them available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
adombeck
force-pushed
the
UDENG-10153-e2e-test-snapshots
branch
from
July 18, 2026 14:09
3cdfa4b to
fe2970e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.