Install cargo-c with --locked - #1731
Merged
Merged
Conversation
The `Build libhimmelblau` step started failing with:
rustc 1.94.0 is not supported by the following package:
cargo-credential-libsecret@0.5.8 requires rustc 1.95
`cargo install cargo-c` resolves transitive dependencies to their
latest compatible versions, so a freshly published dependency that
bumped its MSRV above the CI toolchain's rustc breaks installation even
though our own code is unchanged. Passing --locked makes cargo honor the
crates' own lockfiles, pinning dependencies to versions that build with
the current toolchain. This matches how debian-build.yaml and
auto-updates.yaml already install cargo binaries.
adombeck
added
the
e2e-tests
Contributor
Author
|
@nooreldeenmansour I cherry-picked your commit from #1723 because this failure is blocking other PRs as well |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 88.00% 84.97% -3.03%
==========================================
Files 96 25 -71
Lines 7009 1943 -5066
Branches 112 0 -112
==========================================
- Hits 6168 1651 -4517
+ Misses 785 292 -493
+ Partials 56 0 -56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Building the authd-msentraid broker started failing with
error: failed to compile `cargo-c v0.10.23+cargo-0.97.1`, intermediate artifacts can be found at `/root/.cache/authd-oidc-brokers/cargo-target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
Caused by:
rustc 1.94.0 is not supported by the following package:
cargo-credential-libsecret@0.5.8 requires rustc 1.95
Try re-running `cargo install` with `--locked`
Similarly to the previous commit, we now use `cargo install` with
`--locked`.
adombeck
changed the title
--locked--locked
Contributor
Author
|
There was another |
Contributor
Author
|
Waiting for CI results before requesting review |
adombeck
marked this pull request as ready for review
July 14, 2026 07:06
Contributor
Author
|
The "build broker snap" step succeeds again |
nooreldeenmansour
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build libhimmelblaustep started failing with:cargo install cargo-cresolves transitive dependencies to their latest compatible versions, so a freshly published dependency that bumped its MSRV above the CI toolchain's rustc breaks installation even though our own code is unchanged. Passing --locked makes cargo honor the crates' own lockfiles, pinning dependencies to versions that build with the current toolchain. This matches how debian-build.yaml and auto-updates.yaml already install cargo binaries.Closes #1730
UDENG-10998