Hide terminal password prompt after submission - #1740
Draft
adombeck wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses slow terminal (e.g., sudo) authentication flows where the password prompt remained editable after submission by locking/hiding terminal input while an authentication request is in flight, and re-enabling input on retry.
Changes:
- Add a
submittingstate toformModelto stop processing keystrokes immediately after Enter until a retry restarts the flow. - Add an
inputLockedstate toauthenticationModelto blur (hide) the interactive terminal UI while an auth request is being processed, then refocus on restart. - Add adapter-level tests covering terminal input locking and form submission locking.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pam/internal/adapter/formmodel.go | Adds submitting state to block keystrokes after submission until restart. |
| pam/internal/adapter/authentication.go | Introduces inputLocked to blur/hide terminal UI during in-flight auth requests and refocus on restart. |
| pam/internal/adapter/authentication_test.go | Adds tests for the new locking behavior in terminal and form submission flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Slow authentication requests left the terminal password prompt visible and editable after Enter, even though the submitted value was already in use. Hide the submitted prompt and stop it processing keystrokes until a retry starts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
adombeck
force-pushed
the
1737-password-prompt-remains-editab
branch
from
July 16, 2026 12:13
506b178 to
20e76b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow authentication requests left the terminal password prompt visible and editable after Enter, even though the submitted value was already in use. Hide the submitted prompt and stop it processing keystrokes until a retry starts.
Closes #1737
UDENG-11014