examplebroker: Always set the needed auth steps on new session - #1746
Open
3v1n0 wants to merge 1 commit into
Open
examplebroker: Always set the needed auth steps on new session#17463v1n0 wants to merge 1 commit into
3v1n0 wants to merge 1 commit into
Conversation
We were setting the needed auth steps only for users that are unknown, but not for the ones we already tracked internally. This implied that accessing again with the same MFA user did not lead to another MFA session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the example broker’s NewSession logic to always set neededAuthSteps (and related password-reset flags) for integration-test users based on their username prefix, even when the user is already present in the in-memory exampleUsers map. This fixes repeated logins where MFA users could previously skip MFA because the “needed steps” were only set when the user was first created.
Changes:
- Always apply
neededAuthSteps = 3for MFA-prefixed integration users, regardless of whether they were previously tracked. - Always apply password-reset requirements (
mustReset/canReset) for the relevant integration prefixes, regardless of prior tracking. - Preserve lazy creation of integration users in
exampleUsers(only insert if missing).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were setting the needed auth steps only for users that are unknown, but not for the ones we already tracked internally.
This implied that accessing again with the same MFA user did not lead to another MFA session