efi: a couple of minor chores - #562
Open
alexclewontin wants to merge 2 commits into
Open
Conversation
frederic-hoerni
self-requested a review
September 2, 2026 09:24
Collaborator
|
Please rebase this PR on branch |
alexclewontin
force-pushed
the
check-host-security-chores
branch
from
September 2, 2026 14:36
4d03f4a to
67a5557
Compare
CheckResult.Warnings is a CompoundError interface that RunChecks leaves nil when no warnings were detected. Unwrap on a nil interface panics, so only unwrap when warnings are present.
alexclewontin
force-pushed
the
check-host-security-chores
branch
from
September 2, 2026 14:38
67a5557 to
118ab0e
Compare
Member
Author
|
Rebased, once the tests pass should be good to go |
frederic-hoerni
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of minor fixes, one a comment and one a correctness thing (that wasn't actually getting tripped) in a test.